Skip to content

feat: Quality pack targets - #277

Merged
lurtz merged 13 commits into
eclipse-score:mainfrom
etas-contrib:feature/quality-pack-targets
Sep 10, 2026
Merged

feat: Quality pack targets#277
lurtz merged 13 commits into
eclipse-score:mainfrom
etas-contrib:feature/quality-pack-targets

Conversation

@GabrielPinheiro7891

Copy link
Copy Markdown
Contributor
  • Provide Bazel targets: unit tests, component tests (if existent), code coverage
  • Module documentation with requirements
    Requirements are the SOME/IP protocol specification. Check if we can use/import the openly available protocol spec.
    AUTOSAR spec cannot be used due to IP.
  • Link requirements to tests if possible.

Add 14 comp_reqs across the 7 components (3 per component)
Mark implementing sources with `// # req-Id:` and expose them via per-component `requirement_marked_sources` filegroups
Wire `code_targets` in each component's docs/BUILD
Annotate 3 tests with FullyVerifies/TestType/DerivationTechnique and tag cc_tests as `unit` / `component`
Add //:unit_tests and //:component_tests aggregate suites
Add docs/quality_pack.rst documenting the pack and baseline
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 95086786-5fec-4244-acda-11f8f0af14c7
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_someip_gateway/inc_someip_gateway/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_someip_gateway/inc_someip_gateway/BUILD
INFO: Elapsed time: 12.537s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@GabrielPinheiro7891 GabrielPinheiro7891 changed the title Quality pack targets feat: Quality pack targets Aug 28, 2026
@TimofteBogdan1900
TimofteBogdan1900 self-requested a review August 28, 2026 13:11
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Coverage report for this pull request:

Status: failure (workflow run)
Coverage data: no artifact was produced

The archive contains the HTML report, the raw LCOV data and the JUnit XML test results.

Comment thread docs/quality_pack.rst Outdated
Comment thread docs/quality_pack.rst Outdated
…targets

# Conflicts:
#	score/gateway_ipc_binding/test/BUILD
#	score/serializer/BUILD.bazel
#	score/socom/test/stress/BUILD
#	score/socom/test/unit/BUILD
Comment thread docs/quality_pack.rst Outdated
@@ -0,0 +1,121 @@
..
# *******************************************************************************

@TimofteBogdan1900 TimofteBogdan1900 Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .rst does not fit the S-CORE module template. docs/ is defined as features/, module/ and verification_report/; there is no place for a standalone document at the docs root.
Beside this placement, the content is build and usage instructions rather than module documentation, so README.md is the correct place in my opinion . That readme already have the coverage part

I suggest move this a into the README.md in a section, next to the existing "Coverage report" one:

## Quality pack

Requirements traceability is produced by the documentation build. Run the tests
first: the docs build reads `bazel-testlogs` to link each requirement to the
tests that verify it.

```sh
bazel test //:unit_tests //:component_tests
bazel run //:docs
```

This generates:

- `_build/index.html` — documentation, showing the source-code and test
  links on each requirement
- `_build/needs.json` — the requirements model
- `_build/metrics.json` — traceability metrics

To print the traceability summary on the command line:

```sh
bazel run //:traceability_gate -- --metrics-json "$PWD/_build/metrics.json"
```

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Functional Requirements
-----------------------

.. comp_req:: FlatBuffers gateway configuration schema

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description scopes requirements to the SOME/IP protocol specification. These are derived from the existing implementation instead, so they fall outside that scope — please remove them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Functional Requirements
-----------------------

.. comp_req:: Symmetric IPC binding with split control and payload planes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description scopes requirements to the SOME/IP protocol specification. These are derived from the existing implementation instead, so they fall outside that scope — please remove them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Functional Requirements
-----------------------

.. comp_req:: Bridge local IPC and remote SOME/IP service instances

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description scopes requirements to the SOME/IP protocol specification. These are derived from the existing implementation instead, so they fall outside that scope — please remove them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Functional Requirements
-----------------------

.. comp_req:: Null-passthrough serializer for pre-serialized payloads

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description scopes requirements to the SOME/IP protocol specification. These are derived from the existing implementation instead, so they fall outside that scope — please remove them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Functional Requirements
-----------------------

.. comp_req:: Service-oriented communication runtime

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description scopes requirements to the SOME/IP protocol specification. These are derived from the existing implementation instead, so they fall outside that scope — please remove them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Functional Requirements
-----------------------

.. comp_req:: SOME/IP protocol type and constant definitions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description scopes requirements to the SOME/IP protocol specification. These are derived from the existing implementation instead, so they fall outside that scope — please remove them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Functional Requirements
-----------------------

.. comp_req:: SOME/IP Service Discovery handling

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description scopes requirements to the SOME/IP protocol specification. These are derived from the existing implementation instead, so they fall outside that scope — please remove them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread .github/workflows/quality_pack_comment.yml Outdated
Comment thread .github/workflows/quality_pack_comment.yml Outdated
Comment thread .github/workflows/quality_pack_comment.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml
lurtz
lurtz previously approved these changes Sep 10, 2026
@lurtz
lurtz enabled auto-merge September 10, 2026 09:10
auto-merge was automatically disabled September 10, 2026 11:16

Head branch was pushed to by a user without write access

@lurtz
lurtz enabled auto-merge September 10, 2026 11:43
@lurtz
lurtz added this pull request to the merge queue Sep 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-277: https://eclipse-score.github.io/inc_someip_gateway/pr-277/

Merged via the queue into eclipse-score:main with commit 7497d43 Sep 10, 2026
53 checks passed
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Quality pack traceability report for this pull request:

Status: UNAVAILABLE (workflow run)

No traceability gate output was produced by the CI run.

@lurtz

lurtz commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Quality pack traceability report for this pull request:

Status: UNAVAILABLE (workflow run)

No traceability gate output was produced by the CI run.

@GabrielPinheiro7891 Can you monitor if the added workflows work as expected?

@GabrielPinheiro7891

Copy link
Copy Markdown
Contributor Author

Quality pack traceability report for this pull request:
Status: UNAVAILABLE (workflow run)

No traceability gate output was produced by the CI run.

@GabrielPinheiro7891 Can you monitor if the added workflows work as expected?

Yes, i am checking why it appears as UNAVAILABLE. The CI worked fine and generated the metrics.json. trying to see what happened.

@GabrielPinheiro7891

Copy link
Copy Markdown
Contributor Author

Quality pack traceability report for this pull request:
Status: UNAVAILABLE (workflow run)

No traceability gate output was produced by the CI run.

@GabrielPinheiro7891 Can you monitor if the added workflows work as expected?

So, it's using the link to an old workflow run in the comment posted instead of using the last build which was used to create the comment. #1544 instead of #1555..

@lurtz

lurtz commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

This one seemed to have worked: #177 (comment)

@GabrielPinheiro7891

Copy link
Copy Markdown
Contributor Author

This one seemed to have worked: #177 (comment)

I believe its working fine. This one just tried to pull an old workflow, which is strange, it should pull the workflow of the run it was called upon, but as you saw on other pr it seems its working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants